Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ruff to 0.5, add ruff isort, normalize conda recipes, clean docs to only use makefile commands #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump ruff to 0.5, add ruff isort, normalize conda recipes, clean docs to only use makefile commands #329

wants to merge 1 commit into from

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Jul 13, 2024 •
edited
Loading

  • Update our ruff dependency to 0.5
  • Use and apply isort rules
  • Normalize conda recipes to have same stuff, with comments
  • Clean up docs to avoid getting out of sync with makefile

@timkpaine timkpaine added lang: python Issues and PRs related to the Python codebase part: dependencies PRs that update a dependency file tag: internal Issues and PRs for maintainance of the project - not interesting to external users labels Jul 13, 2024
@timkpaine timkpaine changed the title Bump ruff to 0.5, normalize conda recipes, clean docs to only use makefile commands Bump ruff to 0.5, add ruff isort, normalize conda recipes, clean docs to only use makefile commands Jul 13, 2024
@timkpaine timkpaine marked this pull request as ready for review July 13, 2024 18:18
@timkpaine timkpaine force-pushed the tkp/ruffclean branch 2 times, most recently from 1c0b3d2 to 1e0cb27 Compare August 9, 2024 23:14
@arhamchopra arhamchopra mentioned this pull request Aug 26, 2024
Merged
@timkpaine
Bump ruff to 0.5, normalize conda recipes, clean docs to only use mak…
001e7e7 
…efile commands

Add ruff isort to rules
apply isort
update settings

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robambalu robambalu robambalu left review comments

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

@ptomecek ptomecek Awaiting requested review from ptomecek ptomecek is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
lang: python Issues and PRs related to the Python codebase part: dependencies PRs that update a dependency file tag: internal Issues and PRs for maintainance of the project - not interesting to external users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timkpaine @robambalu @AdamGlustein