-
-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add french abilities translations #1125
Conversation
First things first: congratulations on your first contribution. Well done! Secondly: you've written your Pull Request description very well, good work. Context is key when proposing changes.
Perfect.
A good approach.
I'm not sure what the precedent is for contributions translated this way. @Naramsim have we ever accepted anything like this before? Is there not an official source at all for this? Everything else looks sensible. |
Hi, about ability_prose.csv, the data was scraped (imported) from veekun that relied on ROM/trustworthy contributions. So the text present in the API and Veekun should reflect what's in the game. I think that using AI to translate English text to French is no good because it won't be the exact text found in the game. If a user would like to have this kind of information they can use AI in their project and do the translation on their side. So, I would get rid of everything that's not effectively present in the Pokemon games. |
111c877
to
2518b3e
Compare
Ok I removed the ability_prose file from this PR. Do you have an idea ? |
Yes, maybe we should get rid of those parentheses and clean up the data |
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
Hello this is my first pr to this project :
First of all https://www.pokepedia.fr/ is a very good french pokemon wiki website with accurate informations.
As it lacked some of gen 9 data, i took them directely from the game rom file using PKNX. So i had to remove line breaks character from these one.