Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Shape IDs for Gen IX Pokémon #1127

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

erezushi
Copy link
Contributor

Fixed shape IDs for Gen IX Pokémon, according to the filters on the mobile version of Pokémon HOME

@Naramsim
Copy link
Member

Hi! Is it possible for a pokemon to have different shapes for different games?

@erezushi
Copy link
Contributor Author

So far, there were only 12 Pokémon that had their shape change between games, 11 changed in XY, 1 in ORAS, so basically yes, but it's rare.
What is possible is different forms having different shapes. Specifically in Gen IX, you have a difference between Zero and Hero Palafin, Chest and Roaming Gimmighoul, and between regular Terapagos and its other forms. Here I went with their "default" forms

@Naramsim
Copy link
Member

Ok, so we would need a changelog table here as well. Maybe you can open an issue documenting it and maybe someone will work on it.

@Naramsim
Copy link
Member

In the meantime I'll merge the PR.

@Naramsim Naramsim merged commit e47bfba into PokeAPI:master Sep 16, 2024
4 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants