GitHubAction builds for espeak-py #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial version of a build.sh for GitHub actions
focal and jammy etc change things
bplevin36
reviewed
Oct 7, 2024
.github/workflows/build.yml
Outdated
| strategy: | ||
| matrix: | ||
| platform: | ||
| - runner: ubuntu-20.04 |
There was a problem hiding this comment.
let's just use ubuntu latest for this. 20.04 uses a pretty old GLIBC
There was a problem hiding this comment.
I tried, ubuntu-latest was the cause of the rust wrapper build break.
I suspect something in 22.04 or 24.04 is causing trouble.
bplevin36
reviewed
Oct 7, 2024
bplevin36
approved these changes
Oct 7, 2024
bplevin36
reviewed
Oct 7, 2024
tools/build.sh
Outdated
| fi | ||
| ls | ||
| ./autogen.sh | ||
| ./configure --without-klatt --without-speechplayer --without-mbrola --without-sonic --without-async |
There was a problem hiding this comment.
Suggested change
| ./configure --without-klatt --without-speechplayer --without-mbrola --without-sonic --without-async | |
| ./configure --without-klatt --without-pcaudiolib --without-mbrola --without-sonic --without-async |
Commit this change then try ubuntu-latest again. I think this may have been the problem...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use maturin tooling on GitHub action, turn the steps from README into a build script, and get it to build our key target python versions.