Support optional annotations and service type #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm chart today is platform agnostic and establishes an ingress prerequisite. The proposed solution allows consumers to optionally define platform specific needs (annotations and service type). When omitted, the service will deploy exactly as it does today. When present, annotations and/or service type can be defined and controlled by the consumer.
This can allow for AWS and Azure deployments like so:
values.yaml example for AWS:
values.yaml example for Azure:
Since these are optional, this is backwards compatible.