Skip to content

Commit

Permalink
split out temporal
Browse files Browse the repository at this point in the history
  • Loading branch information
neilkakkar committed Apr 18, 2024
1 parent 3083ed0 commit f02a21f
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
16 changes: 14 additions & 2 deletions .github/actions/run-backend-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ inputs:
description: ClickHouse server image tag, e.g. clickhouse/clickhouse-server:latest
segment:
required: true
description: Either 'FOSS' or 'EE' segment
description: Either 'FOSS' or 'EE' or 'TEMPORAL' segment
concurrency:
required: true
description: Count of concurrency groups
Expand Down Expand Up @@ -132,6 +132,7 @@ runs:
run: bin/check_kafka_clickhouse_up

- name: Wait for Temporal
if: ${{ inputs.segment == 'TEMPORAL' }}
shell: bash
run: |
bin/check_temporal_up
Expand All @@ -157,6 +158,7 @@ runs:
&& './posthog/clickhouse/ ./posthog/hogql/ ./posthog/queries/ ./posthog/api/test/test_insight* ./posthog/api/test/dashboards/test_dashboard.py'
|| 'hogvm posthog'
}} -m "not async_migrations" \
--ignore=posthog/temporal
--splits ${{ inputs.concurrency }} --group ${{ inputs.group }} \
--durations=100 --durations-min=1.0 --store-durations \
$PYTEST_ARGS
Expand Down Expand Up @@ -189,9 +191,19 @@ runs:
--durations=100 --durations-min=1.0 \
$PYTEST_ARGS
- name: Run Temporal tests
id: run-temporal-tests
if: ${{ inputs.segment == 'TEMPORAL' }}
shell: bash
run: |
pytest posthog/temporal -m "not async_migrations" \
--splits ${{ inputs.concurrency }} --group ${{ inputs.group }} \
--durations=100 --durations-min=1.0 --store-durations \
$PYTEST_ARGS
# Post tests
- name: Show docker compose logs on failure
if: failure() && (steps.run-foss-tests.outcome != 'failure' && steps.run-ee-tests.outcome != 'failure' && steps.run-decide-read-replica-tests.outcome != 'failure')
if: failure() && (steps.run-foss-tests.outcome != 'failure' && steps.run-ee-tests.outcome != 'failure' && steps.run-decide-read-replica-tests.outcome != 'failure' && steps.run-temporal-tests.outcome != 'failure')
shell: bash
run: docker compose -f docker-compose.dev.yml logs

Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/ci-backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,12 @@ jobs:
# :NOTE: Keep concurrency and groups in sync
concurrency: [5]
group: [1, 2, 3, 4, 5]
include:
- segment: 'TEMPORAL'
person-on-events: false
clickhouse-server-image: 'clickhouse/clickhouse-server:23.12.5.81-alpine'
concurrency: 1
group: 1

steps:
# The first step is the only one that should run if `needs.changes.outputs.backend == 'false'`.
Expand Down

0 comments on commit f02a21f

Please sign in to comment.