feat(capture): Add setting to be able to disable capture overflow entirely #21168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w (but also not really)
bretthoerner
approved these changes
Mar 28, 2024
| or historical | ||
| not historical | ||
| and settings.CAPTURE_ALLOW_RANDOM_PARTITIONING | ||
| and (distinct_id.lower() in LIKELY_ANONYMOUS_IDS or is_randomly_partitioned(candidate_partition_key)) |
There was a problem hiding this comment.
Love me some parens, and also bringing kafka_partition_key down here.
Co-authored-by: Brett Hoerner <brett@posthog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to be able to skip random partitioning (i.e. overflow) entirely for capture and let plugin-server take the wheel here. See #20945 for more details, #20945 (comment) in particular.
Changes
CAPTURE_ALLOW_RANDOM_PARTITIONINGsetting to support wholesale disabling of random partitioning (i.e. null key overflow routing) for analytics events.Does this work well for both Cloud and self-hosted?
Yes, no impact -- defaults to existing behavior for now.
How did you test this code?
Updated existing test to cover the new setting in both states.