Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: element stats API is only returning rage clicks #21178

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Mar 26, 2024

follow-up to #21097
see: https://posthoghelp.zendesk.com/agent/tickets/12054

that removed the only-add-token mechanism of URL construction which is needed for the heatmap to work

  • we pass in a string https://my-api/stats/?include=a&include=b
  • toolbar fetch - unless you tell it not to converts the query parameters to an object
  • so we end up with { include: b } since objects can't have two identical keys and kea doesn't handle converting it to an array of values
  • rageclicks is the second include so becomes the only type of event we put in the heatmap

@pauldambra pauldambra requested review from benjackwhite and a team March 26, 2024 23:43
Copy link
Contributor

Size Change: +69 B (0%)

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 824 kB +69 B (0%)

compressed-size-action

@marandaneto
Copy link
Member

codewise is fine but I don't know this part of the code at all so it is better if somebody else also looks at it.

@pauldambra pauldambra merged commit 195f0c5 into master Mar 27, 2024
139 checks passed
@pauldambra pauldambra deleted the fix/element_stats branch March 27, 2024 08:34
pauldambra added a commit that referenced this pull request Mar 27, 2024
pauldambra added a commit that referenced this pull request Mar 27, 2024
Revert "fix: element stats API is only returning rage clicks (#21178)"

This reverts commit 195f0c5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants