fix(batch-exports): Create async session in async function #25579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
force-pushed
the
fix/create-session-in-async-func
branch
from
6374ee6
to
3475f70
Compare
tomasfarias
force-pushed
the
fix/create-session-in-async-func
branch
from
3475f70
to
7dfb3cd
Compare
tomasfarias
force-pushed
the
fix/create-session-in-async-func
branch
from
7dfb3cd
to
13069ee
Compare
EDsCODE
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Creating a client session outside async function could have problems (see here). Let's maintain a connection in the context manager, otherwise error.
Changes
Create connection on async context manager
__aenter__.Close connection on
__aexit__.Raise error if attempting to run query outside context manager.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?