CLAUDE.md: put pgxntool's new PostgreSQL-only docs in the API-surface list - #81
Open
jnasbyupgrade wants to merge 1 commit into
Open
Conversation
… list Postgres-Extensions/pgxntool@adb7792 adds `POSTGRES-NOTES.asc` and `CLAUDE-POSTGRES.md` to pgxntool. Both ship to consumers via subtree, so the release review must look at them, but neither can ever produce a `HISTORY.asc` entry: they hold only guidance about PostgreSQL itself, so nothing in them describes pgxntool behavior. A claim in either file that turns out to be about pgxntool is itself the finding -- it belongs in `README.asc`/`CLAUDE.md` instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with Postgres-Extensions/pgxntool#113, which adds
POSTGRES-NOTES.ascandCLAUDE-POSTGRES.mdto pgxntool.Both new files ship to consumers via subtree, so the
/releaseskill's API-documentation review must look at them — the same reasoning that already puts../pgxntool/CLAUDE.mdin scope (item 6). But unlikeCLAUDE.md, neither can ever produce aHISTORY.ascentry: they deliberately hold only guidance about PostgreSQL itself, so nothing in them describes a pgxntool behavior change.The new item 7 says exactly that, and adds the corollary: if a claim in either file turns out to be about pgxntool after all, that is the finding — it belongs in
README.asc/CLAUDE.mdinstead. The old item 7 ("everything else is internal by default") becomes item 8; nothing references these by number.Doc-only; no test changes.
🤖 Generated with Claude Code