ci: pin claude-code-action to a SHA in claude-code-review.yml - #112
Draft
jnasbyupgrade wants to merge 1 commit into
Draft
ci: pin claude-code-action to a SHA in claude-code-review.yml#112jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
This job runs as pull_request_target with pull-requests: write, so a moved upstream tag must not silently change what code runs -- the same reasoning already applied to github-script's pin in ci.yml/protect-label.yml (see those comments). claude-code-action was the one action in this trust class still tracking a mutable tag (@v1) instead of a SHA. `actions/checkout` and claude.yml's own claude-code-action@v1 stay on tags deliberately (existing comments: "so upstream fixes are picked up automatically") -- checkout only reads the base branch, and claude.yml runs under a much narrower trust boundary (actor-gated, read-only permissions), not pull_request_target with write access. This change doesn't touch either. Related changes in pgxntool-test: - Same fix, same rationale, mirrored in its own claude-code-review.yml Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-code-review.yml's job runs aspull_request_targetwithpull-requests: write, so a moved upstream tag must not silently change what code runs -- the same reasoning already applied togithub-script's SHA pin inci.yml/protect-label.yml(see those comments).claude-code-actionwas the one action in this trust class still tracking a mutable tag (@v1) instead of a SHA.actions/checkout(here and elsewhere) andclaude.yml's ownclaude-code-action@v1stay on tags deliberately -- existing comments already explain why ("so upstream fixes are picked up automatically");checkoutonly reads the base branch, andclaude.ymlruns under a narrower trust boundary (actor-gated, read-only permissions), notpull_request_targetwith write access. This PR doesn't touch either.Companion pgxntool-test PR: Postgres-Extensions/pgxntool-test#80