Add support for Rocky and AlmaLinux (which should _for now_ be CentOS like #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note to self: we want a similar change in the roles for other products |
|
note to self: perhaps we should add rocky and alma to the test matrixes too |
|
Confirmed to work on Alma 9, should work on Rocky as well. |
…_databases_credentials When we have a gmysql backend, we do still want to run most of the Mysql-specific setup, apart from the db/user creation. Previously, the pdns_mysql_databases_credentials var was used to trigger this. However, pdns_mysql_databases_credentials contains the database 'root' credentials, and is used when creating the DB/User. Sometimes we don't need/have the root credentials, as the db might be externally provisioned. Yet we still need the mysql-backend dependencies, and might (optionally) also load the default schema. This commit looks at the defined backends, and will trigger the MySQL tasks if it detects a gmysql backend. Additionally, we introduce a boolean parameter `pdns_mysql_schema_load` (default true) so we can allow the user to optionally skip loading the default schema.
…_databases_credentials When we have a gmysql backend, we do still want to run most of the Mysql-specific setup, apart from the db/user creation. Previously, the pdns_mysql_databases_credentials var was used to trigger this. However, pdns_mysql_databases_credentials contains the database 'root' credentials, and is used when creating the DB/User. Sometimes we don't need/have the root credentials, as the db might be externally provisioned. Yet we still need the mysql-backend dependencies, and might (optionally) also load the default schema. This commit looks at the defined backends, and will trigger the MySQL tasks if it detects a gmysql backend. Additionally, we introduce a boolean parameter `pdns_mysql_schema_load` (default true) so we can allow the user to optionally skip loading the default schema.
|
Hi @franklouwers, I have created a new MR (#209 ) for the support of Rocky and AlmaLinux, which includes also testing the installation on those distributions. This MR has additional commits from other MRs. Maybe it makes more sense to just close this MR. |
npmdnl
added a commit
that referenced
this pull request
Jan 16, 2024
Add support and tests for Rocky and AlmaLinux. Supersedes #185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Alma and Rocky linux, assume those are "identical" to CentOS for now.