Merge pull request #3051 from PrismLibrary/dev/ds/cleanup

Cleanup

.github/workflows/build_forms.yml

@@ -23,3 +23,4 @@ jobs:
     with:
       name: Build Prism.Forms
       solution-path: PrismLibrary_Forms.slnf
+      jdk-version: 13

.github/workflows/ci.yml

@@ -51,6 +51,7 @@ jobs:
       solution-path: PrismLibrary_Forms.slnf
       code-sign: true
       artifact-name: Forms
+      jdk-version: 13
     secrets:
       codeSignKeyVault: ${{ secrets.CodeSignKeyVault }}
       codeSignClientId: ${{ secrets.CodeSignClientId }}

Directory.Build.targets

@@ -12,27 +12,4 @@
     <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
   </PropertyGroup>
 
-  <!-- Generate the NotTrimmable.cs file -->
-  <Target Name="AddNotTrimmableFile" BeforeTargets="BeforeCompile" Condition=" $(IsPackable) ">
-    <PropertyGroup>
-      <!-- Define the file path -->
-      <NotTrimmableFilePath>$(IntermediateOutputPath)NotTrimmable.g.cs</NotTrimmableFilePath>
-    </PropertyGroup>
-
-    <!-- Ensure the intermediate output directory exists -->
-    <MakeDir Directories="$(IntermediateOutputPath)" />
-
-    <!-- Write the contents to the file -->
-    <WriteLinesToFile
-      File="$(NotTrimmableFilePath)"
-      Lines="[assembly: System.Reflection.AssemblyMetadata(&quot;IsTrimmable&quot;, &quot;False&quot;)]"
-      Overwrite="true"
-      Encoding="UTF-8" />
-
-    <!-- Include the generated file in the compilation -->
-    <ItemGroup>
-      <Compile Include="$(NotTrimmableFilePath)" />
-    </ItemGroup>
-  </Target>
-
 </Project>

src/Forms/Prism.DryIoc.Forms/Prism.DryIoc.Forms.csproj

@@ -1,8 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
-  <Import Project="Sdk.props" Sdk="MSBuild.Sdk.Extras" Version="$(MSBuildSdkExtrasVersion)" Condition="'$(MSBuildRuntimeType)' != 'Core'" />
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
-    <TargetFrameworks Condition="$(MSBuildRuntimeType) != 'Core'">$(TargetFrameworks);Xamarin.iOS10</TargetFrameworks>
     <Title>DryIoc for Prism for Xamarin.Forms</Title>
     <!-- Summary is not actually supported at this time. Including the summary for future support. -->
     <!--<Summary>DryIoc extensions for Prism for Xamarin.Forms.</Summary>-->
@@ -17,5 +15,4 @@
   <ItemGroup>
     <ProjectReference Include="../Prism.Forms/Prism.Forms.csproj" />
   </ItemGroup>
-  <Import Project="Sdk.targets" Sdk="MSBuild.Sdk.Extras" Version="$(MSBuildSdkExtrasVersion)" Condition="'$(MSBuildRuntimeType)' != 'Core'" />
 </Project>

src/Forms/Prism.Forms/Prism.Forms.csproj

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <RootNamespace>Prism</RootNamespace>
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
-    <TargetFrameworks Condition="$(MSBuildRuntimeType) != 'Core'">$(TargetFrameworks);MonoAndroid10.0</TargetFrameworks>
+    <TargetFrameworks Condition="$(MSBuildRuntimeType) != 'Core'">$(TargetFrameworks);MonoAndroid13.0</TargetFrameworks>
     <Title>Prism for Xamarin.Forms</Title>
     <!-- Summary is not actually supported at this time. Including the summary for future support. -->
     <!--<Summary>Prism for Xamarin.Forms helps you more easily design and build rich, flexible, and easy to maintain Xamarin.Forms applications.</Summary>-->

src/Maui/Prism.Maui/Dialogs/DialogContainerPage.cs

@@ -25,11 +25,11 @@ public DialogContainerPage()
 
     public ICommand Dismiss { get; private set; }
 
-    public async Task ConfigureLayout(Page currentPage, View dialogView, bool hideOnBackgroundTapped, ICommand dismissCommand)
+    public async Task ConfigureLayout(Page currentPage, View dialogView, bool hideOnBackgroundTapped, ICommand dismissCommand, IDialogParameters parameters)
     {
         Dismiss = dismissCommand;
         DialogView = dialogView;
-        Content = GetContentLayout(currentPage, dialogView, hideOnBackgroundTapped, dismissCommand);
+        Content = GetContentLayout(currentPage, dialogView, hideOnBackgroundTapped, dismissCommand, parameters);
 
         await DoPush(currentPage);
     }
@@ -44,7 +44,7 @@ public virtual async Task DoPop(Page currentPage)
         await currentPage.Navigation.PopModalAsync(false);
     }
 
-    protected virtual View GetContentLayout(Page currentPage, View dialogView, bool hideOnBackgroundTapped, ICommand dismissCommand)
+    protected virtual View GetContentLayout(Page currentPage, View dialogView, bool hideOnBackgroundTapped, ICommand dismissCommand, IDialogParameters parameters)
     {
         var overlay = new AbsoluteLayout();
         var popupContainer = new DialogContainerView

src/Maui/Prism.Maui/Dialogs/DialogService.cs

@@ -91,7 +91,7 @@ async Task DialogAware_RequestClose(IDialogResult outResult)
             var dismissCommand = new DelegateCommand(() => dialogAware.RequestClose.Invoke(), dialogAware.CanCloseDialog);
 
             PageNavigationService.NavigationSource = PageNavigationSource.DialogService;
-            dialogModal.ConfigureLayout(_pageAccessor.Page, view, closeOnBackgroundTapped, dismissCommand);
+            dialogModal.ConfigureLayout(_pageAccessor.Page, view, closeOnBackgroundTapped, dismissCommand, parameters);
             PageNavigationService.NavigationSource = PageNavigationSource.Device;
 
             MvvmHelpers.InvokeViewAndViewModelAction<IActiveAware>(currentPage, aa => aa.IsActive = false);

src/Maui/Prism.Maui/Dialogs/IDialogContainer.cs

@@ -6,6 +6,6 @@ public interface IDialogContainer
 {
     View DialogView { get; }
     ICommand Dismiss { get; }
-    Task ConfigureLayout(Page currentPage, View dialogView, bool hideOnBackgroundTapped, ICommand dismissCommand);
+    Task ConfigureLayout(Page currentPage, View dialogView, bool hideOnBackgroundTapped, ICommand dismissCommand, IDialogParameters parameters);
     Task DoPop(Page currentPage);
 }