Merge pull request #3082 from PrismLibrary/dev/ds/maui-dialogs

Fixes Relative Dialog Size
PrismLibrary · Feb 24, 2024 · 285e389 · 285e389
2 parents ba16f1c + 45adedd
commit 285e389
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/e2e/Maui/MauiModule/Dialogs/LoginDialog.xaml b/e2e/Maui/MauiModule/Dialogs/LoginDialog.xaml
@@ -2,6 +2,9 @@
 <Grid xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
       xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
       xmlns:vm="clr-namespace:MauiModule.ViewModels"
+      xmlns:prism="http://prismlibrary.com"
+      prism:DialogLayout.RelativeHeightRequest="0.5"
+      prism:DialogLayout.RelativeWidthRequest="0.8"
       x:DataType="vm:LoginViewModel"
       BackgroundColor="White"
       RowDefinitions="Auto,*"

diff --git a/src/Maui/Prism.Maui/Dialogs/RelativeContentSizeConverter.cs b/src/Maui/Prism.Maui/Dialogs/RelativeContentSizeConverter.cs
@@ -28,6 +28,9 @@ public double RelativeSize
     public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
     {
         var pageSize = double.Parse(value.ToString());
+        if (pageSize < 0)
+            return pageSize;
+
         return RelativeSize * pageSize;
     }