chore: fixing tests

PrismLibrary · Sep 3, 2023 · e93f00c · e93f00c
1 parent dcda09c
commit e93f00c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/src/Forms/Prism.Forms.Regions/Regions/Region.cs b/src/Forms/Prism.Forms.Regions/Regions/Region.cs
@@ -311,7 +311,7 @@ private void InnerAdd(object view, string viewName, IRegionManager scopedRegionM
         /// </summary>
         /// <param name="viewName">The name used when adding the view to the region.</param>
         /// <returns>Returns the named view or <see langword="null"/> if the view with <paramref name="viewName"/> does not exist in the current region.</returns>
-        public virtual VisualElement GetView(string viewName)
+        public virtual object GetView(string viewName)
         {
             if (string.IsNullOrEmpty(viewName))
             {
@@ -431,14 +431,10 @@ private static int ViewSortHintAttributeComparison(ViewSortHintAttribute x, View
             }
         }
 
-        object IRegion.GetView(string viewName)
-        {
-            throw new NotImplementedException();
-        }
-
+        /// <inheritDoc />
         public void RequestNavigate(Uri target, Action<NavigationResult> navigationCallback, INavigationParameters navigationParameters)
         {
-            throw new NotImplementedException();
+            _regionNavigationService.RequestNavigate(target, navigationCallback, navigationParameters);
         }
     }
 }
diff --git a/tests/Forms/Prism.Forms.Regions.Tests/Tests/NavigationAsyncExtensionsFixture.cs b/tests/Forms/Prism.Forms.Regions.Tests/Tests/NavigationAsyncExtensionsFixture.cs
@@ -44,7 +44,8 @@ public void WhenNavigatingWithARelativeStringTarget_ThenNavigatesToRelativeUri()
                 .Setup(nv =>
                     nv.RequestNavigate(
                         It.Is<Uri>(u => !u.IsAbsoluteUri && u.OriginalString == "relative"),
-                        It.Is<Action<NavigationResult>>(c => c != null)))
+                        It.Is<Action<NavigationResult>>(c => c != null),
+                        It.Is<INavigationParameters>(p => p != null)))
                 .Verifiable();
 
             string target = "relative";
@@ -62,7 +63,8 @@ public void WhenNavigatingWithAnAbsoluteStringTarget_ThenNavigatesToAbsoluteUri(
                 .Setup(nv =>
                     nv.RequestNavigate(
                         It.Is<Uri>(u => u.IsAbsoluteUri && u.Host == "test" && u.AbsolutePath == "/path"),
-                        It.Is<Action<NavigationResult>>(c => c != null)))
+                        It.Is<Action<NavigationResult>>(c => c != null),
+                        It.Is<INavigationParameters>(p => p != null)))
                 .Verifiable();
 
             string target = "http://test/path";
@@ -95,7 +97,8 @@ public void WhenNavigatingWithAUri_ThenNavigatesToUriWithCallback()
                 .Setup(nv =>
                     nv.RequestNavigate(
                         target,
-                        It.Is<Action<NavigationResult>>(c => c != null)))
+                        It.Is<Action<NavigationResult>>(c => c != null),
+                        It.Is<INavigationParameters>(p => p != null)))
                 .Verifiable();
 
 

diff --git a/tests/Forms/Prism.Forms.Regions.Tests/Tests/RegionManagerRequestNavigateFixture.cs b/tests/Forms/Prism.Forms.Regions.Tests/Tests/RegionManagerRequestNavigateFixture.cs
@@ -76,14 +76,14 @@ public void WhenNonExistentRegion_ReturnNavigationResultFalse()
         public void DelegatesCallToRegion_RegionSource()
         {
             regionManager.RequestNavigate(region, source);
-            mockNavigation.Verify((r) => r.RequestNavigate(sourceUri, It.IsAny<Action<NavigationResult>>(), null));
+            mockNavigation.Verify((r) => r.RequestNavigate(sourceUri, It.IsAny<Action<NavigationResult>>(), It.IsAny<INavigationParameters>()));
         }
 
         [Fact]
         public void DelegatesCallToRegion_RegionTarget()
         {
             regionManager.RequestNavigate(region, sourceUri);
-            mockNavigation.Verify((r) => r.RequestNavigate(sourceUri, It.IsAny<Action<NavigationResult>>(), null));
+            mockNavigation.Verify((r) => r.RequestNavigate(sourceUri, It.IsAny<Action<NavigationResult>>(), It.IsAny<INavigationParameters>()));
         }
 
         [Fact]
@@ -104,14 +104,14 @@ public void DelegatesCallToRegion_RegionSourceUriParameters()
         public void DelegatesCallToRegion_RegionSourceCallback()
         {
             regionManager.RequestNavigate(region, source, callback);
-            mockNavigation.Verify((r) => r.RequestNavigate(sourceUri, callback, null));
+            mockNavigation.Verify((r) => r.RequestNavigate(sourceUri, callback, It.IsAny<INavigationParameters>()));
         }
 
         [Fact]
         public void DelegatesCallToRegion_RegionTargetCallback()
         {
             regionManager.RequestNavigate(region, sourceUri, callback);
-            mockNavigation.Verify((r) => r.RequestNavigate(sourceUri, callback, null));
+            mockNavigation.Verify((r) => r.RequestNavigate(sourceUri, callback, It.IsAny<INavigationParameters>()));
         }
 
         [Fact]