Fix unhandled dismissal of iOS modals #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
requested changes
Feb 13, 2024
dansiegel
approved these changes
Feb 14, 2024
I've updated PrismNavigationPage to check when disspearing if the modalpresentationstyle is not default. If the page disspears when this style is set to non default & the navigation source is device, the page will be cleaned up with an extra go back call.
Added ios as a target & added compiler directive to the workaround
Axemasta
force-pushed
the
axemasta/fix-3071
branch
from
583415c
to
fd4811d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added an additional check when
PrismNavigationPageis dismissed for the following conditions:ModalPresentationStyle?Device?If both are true, the navigation service will call go back (modal) once, to ensure that the prism navigation service stack matches the true page stack of the maui app.
Bugs Fixed
API Changes
List all API changes here (or just put None), example:
Added:
None
Changed:
None
Behavioral Changes
There should be no behavioural changes
PR Checklist
Currently there are no tests for the change in functionality, I can add them if you think they would be useful