Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContainerProvider for resolving dependencies in XAML #3239

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

chowarth
Copy link
Contributor

Description of Change

Resolves #3238 by adding ContainerProvider<T> based on the previous implementation in Prism.Forms.

Bugs Fixed

N/A

API Changes

Added:

  • ContainerProvider<T>

Behavioral Changes

N/A

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel
Copy link
Member

This is approved but you will need to update the tests to pass

@dansiegel dansiegel added this to the 9.1 milestone Aug 27, 2024
@chowarth
Copy link
Contributor Author

Strange, all passing locally 😞 The only thing I can think of is that I removed the creation of the app using the builder in the two test scenarios, so I've added that back.

@dansiegel dansiegel merged commit ec09b17 into PrismLibrary:master Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add ContainerProvider for resolving dependencies in XAML
2 participants