Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make items.json more goodly for great honor of Prismarine Project and Community #440

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

nickelpro
Copy link
Member

This started as an attempt to fix #199 and got out of control

Stuff this PR does to items.json:

  • Removes non-items across all versions:

    • Air (1.13+ this is typically the only removed "item")
    • Plant stems
    • Liquids
    • Piston Heads
    • Double slabs
    • Fire
    • Redstone Wire
    • Burning Furnace
    • Placed signs
    • You get the idea
  • Removes a bunch of items from 1.7 that aren't in 1.7

  • Add missing items to 1.8+:

    • Magma Block
    • Nether Wart Block
    • Red Nether Block
    • Bone Block
    • Structure Void
  • Add Knowledge Book to 1.12+ (Fixes Missing item (id:453) in 1.12 #199)

  • Fix some random stacksize bugs (ex. 1.7 had doors as stacksize 1)

  • Fixes some display name capitalizations ("mall Disc" -> "Mall Disc")

  • A truly laughable amount of noise from burger-extractor and turbo-inventor re-ordering fields. It's my hope that this is a one-time cost and future runs through the data won't induce so much noise. Post-flattening data versions already mostly used this field order, so now all items.json do.

Now the bad news:
This commit doesn't fix the lack of "variations" provided by pre-flattening data. Ie. All stone still looks the same in items.json. We provide variations inconsistently for a handful of items, but a complete solution will have to be done in a followup

@rom1504
Copy link
Member

rom1504 commented Jul 29, 2021

are the items you removed actually blocks ?

@nickelpro
Copy link
Member Author

Yes, but not blocks that can be obtained as items. They're still available in blocks.json. This is consistent with the behavior of post-flattening items.json, where we've never included non-item blocks

@nickelpro
Copy link
Member Author

For example, right now in pre-flattening items.json sign appears three times. Once as an item, once in it's free-standing block form, and again as it's wall-mounted block form. This PR removes the latter two from items.json

@rom1504 rom1504 merged commit ba957f1 into PrismarineJS:master Jul 29, 2021
@rom1504
Copy link
Member

rom1504 commented Jul 29, 2021

what tool did you use to do this change ?

@nickelpro
Copy link
Member Author

nickelpro commented Jul 29, 2021

Burger, burger-extractor, and turbo-inventor get you 70% of the way there, I have a PR open on burger-extractor that fixes minor displayName bugs (PrismarineJS/burger-extractor#19). There's a bug in Burger that affects pre-flattening stack size which I'm tracking here (Pokechu22/Burger#28) and fixed manually for the purpose of this commit.

Pre-flattening "variations" are not supported by any toolchain currently, what's present in this commit was carried over from the data that was already manually entered into MCD. I'm unsure if this is something Burger can support, but I'll explore that more after the Burger re-factor.

@nickelpro
Copy link
Member Author

Oh and for 1.7 and below everything is scuffed, Burger's identify topping is broken for versions that old so you're completely on your own and all data needs to be manhandled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing item (id:453) in 1.12
2 participants