Make items.json more goodly for great honor of Prismarine Project and Community #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as an attempt to fix #199 and got out of control
Stuff this PR does to items.json:
Removes non-items across all versions:
Removes a bunch of items from 1.7 that aren't in 1.7
Add missing items to 1.8+:
Add Knowledge Book to 1.12+ (Fixes Missing item (id:453) in 1.12 #199)
Fix some random stacksize bugs (ex. 1.7 had doors as stacksize 1)
Fixes some display name capitalizations ("mall Disc" -> "Mall Disc")
A truly laughable amount of noise from burger-extractor and turbo-inventor re-ordering fields. It's my hope that this is a one-time cost and future runs through the data won't induce so much noise. Post-flattening data versions already mostly used this field order, so now all
items.json
do.Now the bad news:
This commit doesn't fix the lack of "variations" provided by pre-flattening data. Ie. All
stone
still looks the same initems.json
. We provide variations inconsistently for a handful of items, but a complete solution will have to be done in a followup