Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metrics for name, email and message validation Fixes #1872 #1874

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sindhuja184
Copy link
Contributor

@sindhuja184 sindhuja184 commented Nov 2, 2024

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
BUG:f&q page is accepting invalid name, e-mail and the message section is accepting message of any length

Fixes: #1872

Description

  1. I made the name field accept only letters
  2. I made a stricter e-mail address such that only the valid emails are accepted
  3. 1 made sure that the content is of minimum length so that the problem explained by the user is easily understandable by the back-end team(> 10characters)

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]
Name:
Before:-
image
After:-
image

e-mail:
Before:-
image
After:-
image

Message:-
Before:-
image
After:-
image

Valid case
image
image

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 9:12am

Copy link
Contributor

github-actions bot commented Nov 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit a2ac174
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/6725ed07f4b1c800085bfa84
😎 Deploy Preview https://deploy-preview-1874--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sindhuja184 sindhuja184 changed the title Added metrics for name, email and message validation Added metrics for name, email and message validation Fixes #1872 Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG:f&q page is accepting invalid name, e-mail and the message section is accepting message of any length
1 participant