Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for n-queens #273

Merged
merged 4 commits into from
May 21, 2020
Merged

add unit test for n-queens #273

merged 4 commits into from
May 21, 2020

Conversation

robinkjoy
Copy link
Contributor

@robinkjoy robinkjoy commented Oct 5, 2019

Added uni test for N-Queens algorithm

For #41

@alxmjo
Copy link
Collaborator

alxmjo commented Oct 24, 2019

Hey @robinkjoy. Thanks for your submission! You can update the readme, too, by adding a ✅next to N Queens in README.md.

@alxmjo alxmjo added the Review pending PR looks good at first glance, needs a full review label Oct 24, 2019
Copy link
Collaborator

@alxmjo alxmjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @robinkjoy. This looks good. Just a few minor requests. Also, please update the README to reflect that N Queens now has a unit test.

C++/test/algorithm/backtracking/n_queens.cpp Outdated Show resolved Hide resolved
C++/test/algorithm/backtracking/n_queens.cpp Show resolved Hide resolved
C++/test/algorithm/backtracking/n_queens.cpp Show resolved Hide resolved
C++/test/algorithm/backtracking/n_queens.cpp Outdated Show resolved Hide resolved
@alxmjo alxmjo self-requested a review May 21, 2020 17:42
@alxmjo alxmjo merged commit 44b7c02 into ProAlgos:master May 21, 2020
EvgenyVRN pushed a commit to EvgenyVRN/Algos that referenced this pull request Aug 20, 2020
* Add unit test for n-queens
* Update readme with white check

Co-authored-by: Alex Johnson <alxmjo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review pending PR looks good at first glance, needs a full review Unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants