Only use compact signature when signature length is 132 chars (0x + 6…

…5 bytes) (#325)
ProjectOpenSea · Jul 27, 2023 · eafcd1c · eafcd1c
1 parent d9a28a9
commit eafcd1c
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/seaport.ts b/src/seaport.ts
@@ -506,14 +506,18 @@ export class Seaport {
 
     const domainData = await this._getDomainData();
 
-    const signature = await signer._signTypedData(
+    let signature = await signer._signTypedData(
       domainData,
       EIP_712_ORDER_TYPE,
       orderComponents,
     );
 
     // Use EIP-2098 compact signatures to save gas.
-    return ethers.utils.splitSignature(signature).compact;
+    if (signature.length === 132) {
+      signature = ethers.utils.splitSignature(signature).compact;
+    }
+
+    return signature;
   }
 
   /**
@@ -541,7 +545,9 @@ export class Seaport {
     );
 
     // Use EIP-2098 compact signatures to save gas.
-    signature = ethers.utils.splitSignature(signature).compact;
+    if (signature.length === 132) {
+      signature = ethers.utils.splitSignature(signature).compact;
+    }
 
     const orders: OrderWithCounter[] = orderComponents.map((parameters, i) => ({
       parameters,