Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seaport 1.3 #990

Draft
wants to merge 77 commits into
base: seaport-1.2
Choose a base branch
from
Draft

Seaport 1.3 #990

wants to merge 77 commits into from

Commits on Feb 1, 2023

  1. Merge pull request #958 from ProjectOpenSea/seaport-1.2 

    Seaport 1.2 Release
    @0age
    0age authored Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3222948 View commit details
    Browse the repository at this point in the history

  2. Update .solcover.js

    @0age
    0age authored Feb 1, 2023
    Configuration menu
    Copy the full SHA
    5a34035 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. readme: update deployed addresses 

    deployed 1.2 across all chains
    @ryanio
    ryanio authored Feb 2, 2023
    Configuration menu
    Copy the full SHA
    ba49fa6 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #961 from ProjectOpenSea/ryan/deploy-1.2-across-ch… 

    …ains
    @0age
    0age authored Feb 2, 2023
    Configuration menu
    Copy the full SHA
    95212f3 View commit details
    Browse the repository at this point in the history

  3. add a test for index overflow with trees of different heights and ref… 

    …actor a bit
    djviau committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    ee295a3 View commit details
    Browse the repository at this point in the history

  4. fix stupid stupid bug

    djviau committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    9e145c0 View commit details
    Browse the repository at this point in the history

  5. add a test that overflowing non-hits fail

    djviau committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    420687e View commit details
    Browse the repository at this point in the history

  6. fix bug

    djviau committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    c3c7227 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #962 from ProjectOpenSea/dan/2023/02/add-bulk-sig-… 

    …index-overflow-test-and-refactor

add a test for index overflow with trees of different heights and refactor a bit
    @0age
    0age authored Feb 2, 2023
    Configuration menu
    Copy the full SHA
    4f2210b View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. Bump http-cache-semantics from 4.1.0 to 4.1.1 

    Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot
    dependabot[bot] authored Feb 4, 2023
    Configuration menu
    Copy the full SHA
    06ad953 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. add SeaportRouter and tests

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    11ab710 View commit details
    Browse the repository at this point in the history

  2. - only set reentrancy on main fn 

    - send funds back once at the end of the fn instead of on every receive
- optimize checking seaport address
    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    8a641c5 View commit details
    Browse the repository at this point in the history

  3. test that seaport address can send ether to router contract

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    418a6a1 View commit details
    Browse the repository at this point in the history

  4. remove fallback

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    9d87b2d View commit details
    Browse the repository at this point in the history

  5. fix lint warnings

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    2592433 View commit details
    Browse the repository at this point in the history

  6. optimization: use newAvailableOrders in place of availableOrders[i]

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    7f5e6a2 View commit details
    Browse the repository at this point in the history

  7. consolidate files into interface

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    fbf805a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. avoid stack too deep errors

    @ryanio
    ryanio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    206fd35 View commit details
    Browse the repository at this point in the history

  2. remove unused constant

    @ryanio
    ryanio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    20eefeb View commit details
    Browse the repository at this point in the history

  3. skip router in ref tests

    @ryanio
    ryanio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    4ae2e23 View commit details
    Browse the repository at this point in the history

  4. define empty memory vars instead of allocating arrays

    @ryanio
    ryanio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    a3161e9 View commit details
    Browse the repository at this point in the history

  5. add disclaimer that router only works for native consideration items

    @ryanio
    ryanio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    0aadb03 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. shorten comment to satisfy line length lint

    @ryanio
    ryanio committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    c873f2a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #966 from ProjectOpenSea/ryan/seaport-router 

    Add SeaportRouter
    @0age
    0age authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    59f6673 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #965 from ProjectOpenSea/dependabot/npm_and_yarn/h… 

    …ttp-cache-semantics-4.1.1

Bump http-cache-semantics from 4.1.0 to 4.1.1
    @0age
    0age authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    e99e1e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. loop through orders again if restricted/contract present

    @0age
    0age committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    8a02c35 View commit details
    Browse the repository at this point in the history

  2. inline a memory read

    @0age
    0age committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    91aed86 View commit details
    Browse the repository at this point in the history

  3. deal with stacc2thicc

    @0age
    0age committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    2a19879 View commit details
    Browse the repository at this point in the history

  4. include updated gas report

    @0age
    0age committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    cc9abe7 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #975 from ProjectOpenSea/second-loop-if-no-open 

    loop through orders again if restricted/contract present
    @0age
    0age authored Feb 13, 2023
    Configuration menu
    Copy the full SHA
    1d7f2f9 View commit details
    Browse the repository at this point in the history

  6. address compiler warning

    @0age
    0age committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    c687f0d View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. do not filter native token executions

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    fb93ce0 View commit details
    Browse the repository at this point in the history

  2. adjust tests accordingly

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    84e7500 View commit details
    Browse the repository at this point in the history

  3. remove only

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    08c6618 View commit details
    Browse the repository at this point in the history

  4. fix lint issues

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6872214 View commit details
    Browse the repository at this point in the history

  5. update reference too

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    cddd085 View commit details
    Browse the repository at this point in the history

  6. use ERC20 in place of Native on filtered on reference

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    cbf8059 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #976 from ProjectOpenSea/no-skipping-native-token-… 

    …executions

do not filter native token executions
    @0age
    0age authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    8e6bb2b View commit details
    Browse the repository at this point in the history

  8. First commit

    @BCLeFevre
    BCLeFevre committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    73ec734 View commit details
    Browse the repository at this point in the history

  9. Skip reference for now

    @BCLeFevre
    BCLeFevre committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    a1051dc View commit details
    Browse the repository at this point in the history

  10. use big switch instead of typehash directory

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    572489d View commit details
    Browse the repository at this point in the history

  11. update gas report

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    9ad538d View commit details
    Browse the repository at this point in the history

  12. linting, cleanup, and a tiny refactor

    djviau committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    61d6d20 View commit details
    Browse the repository at this point in the history

  13. Merge pull request #980 from ProjectOpenSea/dan/2023/02/linting-etc-o… 

    …n-ben/ZoneContractOrderValidator

linting, cleanup, and a tiny refactor
    @BCLeFevre
    BCLeFevre authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    89c9879 View commit details
    Browse the repository at this point in the history

  14. Fix reference, rename test zone

    @BCLeFevre
    BCLeFevre committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    18bd267 View commit details
    Browse the repository at this point in the history

  15. Update contracts/lib/ConsiderationBase.sol

    @0age
    0age authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    4b37cb3 View commit details
    Browse the repository at this point in the history

  16. Merge pull request #979 from ProjectOpenSea/1.3-typehash-optimization

    @0age
    0age authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    3695c90 View commit details
    Browse the repository at this point in the history

  17. update version to 1.3

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b20d35e View commit details
    Browse the repository at this point in the history

  18. Merge pull request #982 from ProjectOpenSea/1.3-bump-version 

    update version to 1.3
    @0age
    0age authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e8ead7e View commit details
    Browse the repository at this point in the history

  19. move excess native token transfer to before post-execution checks

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    8c54f89 View commit details
    Browse the repository at this point in the history

  20. Merge pull request #983 from ProjectOpenSea/1.3-return-excess-native-… 

    …before-checks

move excess native token transfer to before post-execution checks
    @0age
    0age authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e3e791e View commit details
    Browse the repository at this point in the history

  21. Add failing test for 1.2->1.3

    @BCLeFevre
    BCLeFevre committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    84a6b12 View commit details
    Browse the repository at this point in the history

  22. Add switch based on version

    @BCLeFevre
    BCLeFevre committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    bd335ca View commit details
    Browse the repository at this point in the history

  23. refactor typehash lookup as while loop

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    745ea67 View commit details
    Browse the repository at this point in the history

  24. add test (still need zone)

    @stephankmin
    stephankmin committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c7ae394 View commit details
    Browse the repository at this point in the history

  25. fix a constant

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    436ce75 View commit details
    Browse the repository at this point in the history

  26. add zone, update abridged interfaces

    @stephankmin
    stephankmin committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e1370ae View commit details
    Browse the repository at this point in the history

  27. Merge pull request #978 from ProjectOpenSea/ben/ZoneContractOrderVali… 

    …dator

Transfer Validation Zone/Offerer
    @0age
    0age authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    4c3a4de View commit details
    Browse the repository at this point in the history

  28. Merge pull request #986 from ProjectOpenSea/1.3-typehash-while-loop 

    refactor typehash lookup as while loop
    @0age
    0age authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6e6d006 View commit details
    Browse the repository at this point in the history

  29. Merge branch '1.3' into stephan/1.3-forge-tests

    @stephankmin
    stephankmin authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    714cf8b View commit details
    Browse the repository at this point in the history

  30. add seaport-sol

    @jameswenzel
    jameswenzel authored and GitHub Actions Bot committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6bc735f View commit details
    Browse the repository at this point in the history

  31. test fulfillavailableorders with post-execution validation zone, add … 

    …sol helpers
    @jameswenzel
    jameswenzel authored and GitHub Actions Bot committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    68fb478 View commit details
    Browse the repository at this point in the history

  32. tweak comments

    @jameswenzel
    jameswenzel authored and GitHub Actions Bot committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    5129151 View commit details
    Browse the repository at this point in the history

  33. Merge pull request #985 from ProjectOpenSea/james/fulfill-available-p… 

    …ost-execution

TestTransferValidationZoneOfferer fulfillAvailable tests with conduit + Add sol helpers
    @0age
    0age authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    85f395a View commit details
    Browse the repository at this point in the history

  34. Merge pull request #984 from ProjectOpenSea/1.3 

    1.3
    @0age
    0age authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    718670a View commit details
    Browse the repository at this point in the history

  35. Merge pull request #987 from ProjectOpenSea/stephan/1.3-forge-tests 

    Stephan/1.3 forge tests
    @0age
    0age authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    28c657c View commit details
    Browse the repository at this point in the history

  36. lint

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6560958 View commit details
    Browse the repository at this point in the history

  37. move TypehashDirectory to test/

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    ddea2c1 View commit details
    Browse the repository at this point in the history

  38. reset gas profile

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    47e5d84 View commit details
    Browse the repository at this point in the history

  39. bump package.json version

    @0age
    0age committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    bbe5c77 View commit details
    Browse the repository at this point in the history

  40. Merge pull request #989 from ProjectOpenSea/1.3-final-cleanup 

    1.3 final cleanup
    @0age
    0age authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    2560c03 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Use a ternary function for typehashes, replace for-break with functio… 

    …n-leave

Difference is pretty negligible in terms of gas/code, but it is a bit easier to follow
    @d1ll0n
    d1ll0n committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    25c94ce View commit details
    Browse the repository at this point in the history

  2. Exit the loop -> Exit the function

    @d1ll0n
    d1ll0n committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    ba151b7 View commit details
    Browse the repository at this point in the history

  3. clean up a little more

    @0age
    0age committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    ef24393 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #991 from ProjectOpenSea/typehash-lookup-readability 

    Improve typehash lookup readability
    @0age
    0age authored Feb 15, 2023
    Configuration menu
    Copy the full SHA
    059db17 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #992 from ProjectOpenSea/main 

    Refactor bulk order typehash lookup
    @0age
    0age authored Feb 15, 2023
    Configuration menu
    Copy the full SHA
    07ffaea View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Add v1.3 deployment addresses

    @0age
    0age authored Feb 17, 2023
    Configuration menu
    Copy the full SHA
    2b8103a View commit details
    Browse the repository at this point in the history