Update stage names for pre-commit
#2296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pre-commit` v4.0.0 added a warning to deprecated stage names[1] so update these names to avoid the warning. This also required updating the minimum `pre-commit` version to one that supports the new names See also[2] for a similar change and the docs[3]. [1] https://github.com/pre-commit/pre-commit/blob/cc4a52241565440ce200666799eef70626457488/CHANGELOG.md#400---2024-10-05 [2] pre-commit/pre-commit-hooks@003dfa5 [3] https://pre-commit.com/#confining-hooks-to-run-at-certain-stages Fixes: PyCQA#2294
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 39 39
Lines 3091 3091
Branches 748 748
=======================================
Hits 3065 3065
Misses 15 15
Partials 11 11 |
Rotzbua
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commitv4.0.0 added a warning to deprecated stage names[1] so update these names to avoid the warning. This also required updating the minimumpre-commitversion to one that supports the new namesSee also[2] for a similar change and the docs[3].
[1] https://github.com/pre-commit/pre-commit/blob/cc4a52241565440ce200666799eef70626457488/CHANGELOG.md#400---2024-10-05
[2] pre-commit/pre-commit-hooks@003dfa5
[3] https://pre-commit.com/#confining-hooks-to-run-at-certain-stages
Fixes: #2294