This repository has been archived by the owner on May 11, 2021. It is now read-only.
Add Code of Conduct & Privacy Policy to new events #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time, all of the "static" pages were stored inside the
templates folder of the
frontend
application. This had the advantageof being able to see the change history of documents such as the Code of
Conduct and Privacy Policy. This disadvantage was that applications with
multiple events would have the same copy for the pages.
0418bda introduced the
AboutPage
model. This model was used to movemany of the "static" pages out of the templates and into the database.
This not only allowed events to have their own version of page, but
events could have their own set of pages. It also introduced the
advantage of being able to update the copy on a page without deploying
code.
The disadvantage here is that it becomes harder for people to track
changes we make to the aforementioned documents. Given their nature, the
more transparent we can be able them, the better.
This changeset not only gives us the ability to begin tracking the
changes we make to them, but it also allows us to prepopulate them when
adding new events through the
create_event
management command.While it isn't required that we make all changes to the Code of Conduct
and Privacy Policy through the new reStructuredText documents being
added here, it should be strongly encouraged that we do so.
If we follow this policy, the overhead to make changes to the pages
actually goes up, but I believe the ends justify the means.