test(desktop): validate release arguments against the Electron Builder schema

[elkaix]

Related Issue

No issue — follow-up hardening for the release failure fixed in #167.

Problem

The desktop-v0.2.1 build died at Electron Builder's schema validation on --config.win.publisherName, an option removed in v26. The suite was green throughout, because package-win.spec.ts compared the generated argument array to a hand-written expected array. Both copies carried the same mistake, so the test only detected change, never invalidity — Google's "change-detector test".

The consequence is structural, not incidental: these arguments are only emitted when signing secrets are present, so a tag build is the first time they ever execute. A test that cannot judge them means the release is the first judge.

What changed

package-win.spec.ts now merges the generated --config.* arguments onto the packaged build configuration and validates the result with Ajv against the installed app-builder-lib/scheme.json, using the same Ajv options app-builder-lib itself validates with (allErrors, verbose, coerceTypes, strict: false).

• No new dependency. Both scheme.json and ajv resolve through the existing electron-builder dependency (pnpm hides them from a direct resolve out of apps/desktop, so resolution is anchored at require.resolve('electron-builder')).
• Follows the installed version. It reads whatever schema the pinned Electron Builder ships, so a future major that relocates these options fails here rather than at a tag.
• Failure output is trimmed to the actionable errors instead of Ajv's verbose dump.

Three cases: the packaged configuration alone, the configuration each signing method produces, and a negative case pinning the exact regression.

Verification

Mutation-tested, both caught:

Mutation	Result
Reintroduce --config.win.publisherName	3 failed — Electron Builder rejects unknown options: /win.publisherName
Drop required azureSignOptions.certificateProfileName	3 failed — must have required property 'certificateProfileName'
Restored	17 passed

The second case is a class the previous test could not detect at all.

• pnpm exec vitest run tests/package-win.spec.ts — 17 passed
• pnpm run typecheck (apps/desktop) — clean, both tsconfigs
• oxlint --type-aware — 0 warnings, 0 errors
• scripts/check-no-comments.mjs — OK

Checklist

• I have read the CONTRIBUTING document.
• I have linked a related issue — none; follow-up to fix(desktop): correct the Windows and macOS release verification #167.
• I have added tests that prove my feature works.
• Ran gen-changesets skill, or this PR needs no changeset — no changeset: test-only, nothing users can perceive.
• Ran gen-docs skill, or this PR needs no doc update.

Summary by CodeRabbit

• Tests
  • Improved validation of desktop package configurations against the Electron Builder schema.
  • Added coverage for base configurations, signing modes, invalid options, and removed settings.
  • Enhanced error reporting for unknown or invalid configuration values.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8979a443-6a28-4ae1-a2c9-b2b7d748e7e6

📥 Commits

Reviewing files that changed from the base of the PR and between 78462b0 and 141db8d.

📒 Files selected for processing (1)

• apps/desktop/tests/package-win.spec.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The Windows packaging tests now load Electron Builder’s schema, reconstruct merged configurations from command-line arguments, validate them with Ajv, and cover base, Azure signing, certificate signing, and removed-option scenarios.

Changes

Windows configuration validation

Layer / File(s)	Summary
Schema loading and configuration validation apps/desktop/tests/package-win.spec.ts	The tests load the Electron Builder schema and use Ajv to validate complete reconstructed configurations. Validation errors distinguish unknown options from other schema failures.
Packaging scenario coverage apps/desktop/tests/package-win.spec.ts	The tests validate the base configuration, Azure signing configuration, certificate signing configuration, and rejection of win.publisherName.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 141db

This PR strengthens release-configuration tests by validating generated arguments against the installed Electron Builder schema; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title uses a valid conventional-commit prefix and imperative wording, but it exceeds the 72-character limit at 77 characters.	Shorten the title to 72 characters or fewer while preserving its description of schema validation tests.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description clearly explains the problem, implementation, validation results, and checklist; it does not provide a direct related-issue link.
Docstring Coverage	✅ Passed	Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

_{Comment @coderabbitai help to get the list of available commands.}

[pkg-pr-new]

pnpm dlx https://pkg.pr.new/@pymodel/pythinker-code@141db8d

npx https://pkg.pr.new/@pymodel/pythinker-code@141db8d

commit: 141db8d