Remove hardcoded MACOSX_DEPLOYMENT_TARGET

PyO3 · Dec 8, 2022 · 7c069cd · 7c069cd
1 parent 3f50598
commit 7c069cd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -11874,10 +11874,13 @@ async function innerMain() {
                 await installRustTarget('x86_64-apple-darwin', rustToolchain);
             }
             await installRustTarget('aarch64-apple-darwin', rustToolchain);
-            env.DEVELOPER_DIR = '/Applications/Xcode.app/Contents/Developer';
-            env.SDKROOT =
-                '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk';
-            env.MACOSX_DEPLOYMENT_TARGET = '10.9';
+            if (!env.DEVELOPER_DIR) {
+                env.DEVELOPER_DIR = '/Applications/Xcode.app/Contents/Developer';
+            }
+            if (!env.SDKROOT) {
+                env.SDKROOT =
+                    '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk';
+            }
             core.endGroup();
         }
         let fullCommand = `${maturinPath} ${args.join(' ')}`;

diff --git a/src/index.ts b/src/index.ts
@@ -702,10 +702,13 @@ async function innerMain(): Promise<void> {
         await installRustTarget('x86_64-apple-darwin', rustToolchain)
       }
       await installRustTarget('aarch64-apple-darwin', rustToolchain)
-      env.DEVELOPER_DIR = '/Applications/Xcode.app/Contents/Developer'
-      env.SDKROOT =
-        '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk'
-      env.MACOSX_DEPLOYMENT_TARGET = '10.9'
+      if (!env.DEVELOPER_DIR) {
+        env.DEVELOPER_DIR = '/Applications/Xcode.app/Contents/Developer'
+      }
+      if (!env.SDKROOT) {
+        env.SDKROOT =
+          '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk'
+      }
       core.endGroup()
     }