[fix Parser.py] fixed up the class Parser can not parser subckt by a mistake, #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…takely use isinstance to compare 'SubCircuitStatement' and 'SubCircuit'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That mistakely use isinstance to compare 'SubCircuitStatement' and 'SubCircuit',SubCircuitStatement is a new class in Parser.py to save the parsered statment begin with ".subckt" and end with ".ends".But "SubCircuit" is a class in Netlist.py.SO, WHEN WE TRY TO build_circuit by parser with a member "statement" the SubCircuitStatement is always skiped by mistake. I just fixed it. Just fixed a word in code, please merge it.
To make it easier to merge your pull request, you should divide your PR into smaller and easier-to-verify units.
Please do not make a pull requests with a lot of modifications which are difficult to check. If I merge
pull requests blindly then there is a high risk this software will become a mess quickly for everybody.