Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Node.js 16 compatible action #4897

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

williamfgc
Copy link
Contributor

Proposed changes

Current GitHub Action for self-hosted runners doesn't work with node.js 12 triggering a spurious message on ornl CI.
Node.js 12 support was deprecated last year.
This is PR upgrade the problem with a compatible action with the same functionality.
It needs to be merged first in order to be tested.

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

N/A

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@ye-luo
Copy link
Contributor

ye-luo commented Jan 10, 2024

Test this please

@ye-luo ye-luo enabled auto-merge January 10, 2024 15:09
@ye-luo ye-luo merged commit 95807ae into QMCPACK:develop Jan 10, 2024
38 checks passed
@williamfgc williamfgc deleted the ci-action-upgrade branch January 10, 2024 19:29
@ye-luo
Copy link
Contributor

ye-luo commented Jan 10, 2024

@williamfgc Did you see the issue being resolved in the CI of #4898?

@williamfgc
Copy link
Contributor Author

@ye-luo yes, it's resolved. PR #4898 ornl CI doesn't show the warnings at the bottom of this PR ornl CI. Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants