-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly set OpenMP runtime library rpath like other normal libraries #5192
Conversation
Test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain how this helps someone running build/bin/qmcpack ? It does look like it will help for ctest runs.
We'll also have to carefully test on e.g. a good sampling of the different platforms we have build recipes for.
Test this please |
BUILD_RPATH embeds rpath/runpath when linking executables in the build directory. When we run ctest, this info will be used for look up libraries although the priority is lower than environment variable LD_LIBRARY_PATH. Once QMCPACK is built and/or installed. There is no longer a need to handle LD_LIBRARY_PATH for looking up OpenMP runtime libraries of any compiler at runtime. |
Test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test this please |
Proposed changes
This should resolve OpenMP runtime library mismatch issue at runtime.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist