Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer using ST type in C2R #5203

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Oct 17, 2024

Proposed changes

The transferred values are used in ST anyway. There is no need to transfer with a higher precision TT.
I made the change when implementing C2C but forgot to update C2R.

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo
Copy link
Contributor Author

ye-luo commented Oct 17, 2024

Test this please

Copy link
Contributor

@rcclay rcclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ye-luo
Copy link
Contributor Author

ye-luo commented Oct 18, 2024

Test this please

@ye-luo ye-luo enabled auto-merge October 18, 2024 14:57
@ye-luo ye-luo merged commit b250174 into QMCPACK:develop Oct 18, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants