Fix FTE_PEXT_TRANS and FTE_PEXT_COLOURMOD #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, need to update the CI here since CMake transition, and should probably just build dynamically linked on Linux to make it fast. No value added by having the Windows build here, nor having multiple archs of Linux, as the protocol is the same on all OSes. |
The extension was incorrectly implemented from the beginning. To support the extra bits support for PF_EXTRA_PFS is needed which results in an extra byte of player flags. With a 24 bit player flags PF_ONGROUND and PF_SOLID are then found at a higher offset. This added offset is typically emulated by upshifting the relevant bits in incoming data if PEXT_TRANS is not part of the extensions the client announces support for to be able to use the same definitions in both cases.
Support for colourmod was partially declared in protocol.h, but missing the entity_state_t bytes, as well as a few defines. colourmod[3] is r/g/b with 1/32 precision, thus a value of 32 corresponds to 1.0f, which in effect means no color modification, and the same is true for 0.0f. Values above 1.0f yields overbrights.
dsvensson
force-pushed
the
trans-and-colourmod
branch
from
02aeb9e
to
53e1440
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.