Add CMake option USE_BUNDLED_BLAS_WIN
#1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option controls whether CMake uses the bundled OpenBLAS library when building on Windows (defaults to True). Having this option allows a user to build qiskit-aer against a different system BLAS without needing to specify a full path using the `AER_BLAS_LIB_PATH` option.
5 tasks
|
@doichanj What can I do to move this forward? It was passing before but ran out of heap space after you merged in main. I also wasn't sure about the name I chose for the option. Also, off topic, but I would be interested in any feedback on #1923. With that issue resolved and the PR here, I could have full platform support for qiskit-aer on conda-forge. |
doichanj
approved these changes
Nov 29, 2023
doichanj
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a CMake option
USE_BUNDLED_BLAS_WINto control whether the bundled BLAS library is used on WindowsDetails and comments
This option controls whether CMake uses the bundled OpenBLAS library when building on Windows (defaults to True). Having this option allows a user to build qiskit-aer against a different system BLAS without needing to specify a full path using the
AER_BLAS_LIB_PATHoption.Having this option helps with building qiskit-aer with conda by letting CMake follow its standard library search process.