Update Sphinx theme #1946
Update Sphinx theme #1946
Conversation
|
|
docs/conf.py
Outdated
|
|
||
| html_logo = 'images/logo.png' | ||
| #html_logo = 'images/logo.png' |
There was a problem hiding this comment.
This should be deleted. It's better to not have commented out code: https://bytedev.medium.com/code-comment-anti-patterns-and-why-the-comment-you-just-wrote-is-probably-not-needed-919a92cf6758#:~:text=Avoid%20commenting%20out%20code%20and,to%20another%20team%20member%27s%20work.
There was a problem hiding this comment.
Okay! Thank you Eric!
docs/conf.py
Outdated
|
|
||
| html_logo = 'images/logo.png' | ||
| #html_logo = 'images/logo.png' | ||
| #html_sidebars = {'**': ['globaltoc.html']} |
There was a problem hiding this comment.
This can also be deleted
…te-sphinx-theme
…iskit-aer into update-sphinx-theme
|
Yes, the reason is the increasing on the time building the documentation, and the size of the files compared with the old theme. I will fix it soon in another PR, but in the meantime, I let it as a draft. I should have updated the comment in this PRs before with the information, but here you can see the details:
|
|
Thanks @doichanj! Arnau doesn't have write access so will need a maintainer to merge. |
* Update Sphinx theme * importlib-metadata constraint removed * Update conf.py --------- Co-authored-by: Jun Doi <doichan@jp.ibm.com>
Summary
Updates to new Ecosystem theme.
Total file size increased (31.8 MB -> 151 MB)
index.html size increased (9 KB → 149 KB)
Build time increased (343s → 621s)
For more information: Qiskit/qiskit_sphinx_theme#232