Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required memory estimation for MPS #2059

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

doichanj
Copy link
Collaborator

Summary

This PR fixes estimation of required memory size for MPS method #2056

Details and comments

Estimated too large required memory because memory size was increased by all the 2-qubit gates.

Also this PR adds option to ignore check of required memory vs input circuit if max_memory_mb=-1 is set

@doichanj doichanj added stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the Fixed section of the changelog labels Feb 14, 2024
@doichanj doichanj added this to the Aer 0.14.0 milestone Feb 14, 2024
@doichanj doichanj requested a review from hhorii February 14, 2024 08:10
Copy link
Collaborator

@hhorii hhorii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhorii hhorii merged commit 5991cf8 into Qiskit:main Feb 20, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the Fixed section of the changelog stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants