Pcvl 749 Remove python 3.8 #459
Conversation
There was a problem hiding this comment.
With @MarionQuandela, we found that some stuffs will raise errors. She will add them as comments in her review soon.
| @@ -310,7 +309,7 @@ | |||
| "metadata": {}, | |||
| "outputs": [], | |||
| "source": [ | |||
| "def mzi(name:str, theta:Union[float, pcvl.Parameter], phi:Union[float, pcvl.Parameter],theta_2:Union[float, pcvl.Parameter]) -> pcvl.Circuit:\n", | |||
| "def mzi(name:str, theta:float | pcvl.Parameter, phi:float | pcvl.Parameter, theta_2:float | pcvl.Parameter) -> pcvl.Circuit:\n", | |||
There was a problem hiding this comment.
| is only working from python 3.10 and we still support python 3.9.
https://docs.python.org/3.10/whatsnew/3.10.html#pep-604-new-type-union-operator
But do not loose hope, you can add at the top of the import from __future__ import annotations (it's very important to put it as the first import) and we will delete this import in 3.10 (it's already elsewhere in the code)
There was a problem hiding this comment.
So, is this still to be fixed?
There was a problem hiding this comment.
We're inside the pull request regarding this issue, you tell me Marion did it, but where is the diff showing the fix?
I expect from __future__ import annotations to be added somewhere on top of this file. I might be blind but I can't find it.
| @@ -581,10 +580,10 @@ def compute_unitary(self, | |||
| @staticmethod | |||
| @deprecated(version="0.10.0", reason="Construct a GenericInterferometer object instead") | |||
| def generic_interferometer(m: int, | |||
| fun_gen: Callable[[int], ACircuit], | |||
| shape: Union[str, InterferometerShape] = InterferometerShape.RECTANGLE, | |||
| fun_gen: callable[[int], ACircuit], | |||
There was a problem hiding this comment.
callable[something] is not a correct type for hinting, you must use from collections.abc import Callable.
This is not causing any error because it's not used anywhere.
You can see code example in perceval/components/generic_interferometer.py GenericInterferometer.__init__
|
I this you can also remove the method _removesuffix in perceval/utils/persistent_data.py and replace it with removesuffix |
No description provided.