Add Lookup and misc updates. #14
Conversation
|
cc @rossbar |
|
and @tupui |
Carreau
force-pushed
the
lookup
branch
2 times, most recently
from
b547fa5
to
626aa65
Compare
|
Cool thanks 😃 |
intersphinx_registry/lookup.py
Outdated
| if len(sys.argv) < 2: | ||
| sys.exit("Usage: python -m intersphinx_registry.lookup [packages...]") | ||
|
|
||
| packages = set(sys.argv[1:]) |
There was a problem hiding this comment.
set will not respect order so it might be better to explicitly iterate?
There was a problem hiding this comment.
Yeah, but get_intersphinx_mapping takes a set and mypy complains otherwise.
I don't think it will be used much with many packages, so I think we can have the order random for now and figure out if we want a stable order.
There was a problem hiding this comment.
It might actually be worth limiting it to one library at a time - if you had multiple .inv files in the same pager it might be harder to figure out which :external library to map back to. FWIW I think the python -m sphinx.ext.intersphinx lookup only supports one-at-a-time.
intersphinx_registry/lookup.py
Outdated
| ] | ||
|
|
||
|
|
||
| import logging as _logging |
There was a problem hiding this comment.
move logging to the top.
python -m intersphinx_registry.lookup [package names] Not direction -m intersphinx_registry in case we want to add functionalities later.
|
Ok, it can only lookup one for now. |
No description provided.