ENH - Generalise action #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
type: enhancement 💅🏼
|
Aha! I finally managed to solve the damn yarn and linking issues! and we should not be constrained to lumino linking only |
gabalafou
reviewed
Jul 12, 2023
gabalafou
approved these changes
Jul 12, 2023
Co-authored-by: gabalafou <gabriel@fouasnon.com>
|
Just a note. I noticed that the link external package action still has wording that implies that it's meant to be used for Lumino, even though the intent of the PR is to generalize beyond Lumino |
|
Thanks @gabalafou. I just pushed two commits:
Test-wise, I have been triggering the action manually on this branch with different refs and all seems ok, I think that is for now the best way to test the actions/workflow (see https://github.com/Quansight-Labs/jupyter-a11y-testing/actions/runs/5531119468) |
|
Will merge now! |
gabalafou
added a commit
that referenced
this pull request
Aug 1, 2023
* 🔧 Get name from package * 🔧 Update pre-commits * ✏️ Remove new line * ♻️ Jupyterlab is now on main * 👷 Fix branch in actions * ⏪ Revert changes - we want to use yarn to link package * 👷 Minor enhancements to action summary * 🐛 Pass the path to the linked package * 🔧 Update external package path * ♻️ Move linked package summary to action * Move working directory to top of step * 📝 Update readmes * 🐛 Capture path instead * 🔧 Use vanilla jq for name * 👷 Use yarn 3 syntax * Should only link once * Docs improvements * Update .github/actions/link-package/action.yml Co-authored-by: gabalafou <gabriel@fouasnon.com> * Better format inputs docs * 📝 Remove hard references to Lumino --------- Co-authored-by: gabalafou <gabriel@fouasnon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we can build JupyterLab and build and link lumino (hardcoded on the action workflow). Since we want to enable the testing with libraries other than lumino (e.g. notebook, accessible themes) we need to update the action to be more generalisable.
This PR should enable the generalisation of packages or tools linked to JupyterLab and some minor updates:
package.jsonof the package to be linked for build and setup steps