fix ldexp casting + unary ufunc dtypes #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lezcano
reviewed
Aug 1, 2023
torch_np/_ufuncs.py
Outdated
Comment on lines
166
to
176
| if dtype is not None: | ||
| if isinstance(x1, torch.Tensor): | ||
| x1 = _util.typecast_tensor(x1, dtype, casting) | ||
| else: | ||
| x1 = torch.as_tensor(x1, dtype=dtype) | ||
| else: | ||
| if not isinstance(x1, torch.Tensor): | ||
| x1 = torch.as_tensor(x1) | ||
| if _dtypes_impl._category(x1.dtype) < 2: | ||
| # cast integers to float64 | ||
| x1 = x1.double() |
There was a problem hiding this comment.
Could we reuse the unary ufunc machinery for this one?
There was a problem hiding this comment.
.double() is actually wrong because we allow for user control of the default dtypes, so it needs to be default_dtypes.float_dtype. Ditto for unary ufuncs, and I've extracted the relevant three-liner into _util in the updated PR. Does that count as a reuse in your books? :-).
lezcano
approved these changes
Aug 1, 2023
lezcano
reviewed
Aug 1, 2023
|
Merged, thanks for the review @lezcano ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the second commit is just trivial MAINT while I'm looking at this file