Skip to content

fix: reject nested account action fields - #62

Merged
Pigbibi merged 1 commit into
mainfrom
fix/advisor-nested-action-validation
Aug 23, 2026
Merged

fix: reject nested account action fields#62
Pigbibi merged 1 commit into
mainfrom
fix/advisor-nested-action-validation

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • recursively reject account-action keys anywhere in an advisory artifact
  • cover broker, order, account action, target quantity, target weight, and camel-case variants
  • report only offending key paths and leave ordinary research text untouched

Validation

  • python -m pytest -q
  • 300 passed
  • ruff check on changed files
  • git diff --check

V5/V6 assessment

The default producer still emits schema v5, which intentionally rejects v6 expiry and freshness fields. Artifact and manifest digests already exist downstream, but the default report does not carry a top-level input-content digest. Flipping the default should be a separate dual-read v6 migration because preview bundle, workspace, D3 evidence scripts, and workflows currently pin v5.

Safety

  • no broker or live integration is added
  • no account allocation fields are introduced
  • validation becomes fail-closed for nested execution-shaped data

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit 8fe1303 into main Aug 23, 2026
3 checks passed
@Pigbibi
Pigbibi deleted the fix/advisor-nested-action-validation branch August 23, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant