-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: a bug that error in the middleware occurs 404 #6951
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 27143e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
@@ -8,8 +8,7 @@ export const onRequest: RequestHandler = async ({ next }) => { | |||
error && | |||
typeof error === 'object' && | |||
'message' in error && | |||
typeof error.message === 'string' && | |||
error.message == 'ERROR: Demonstration of an error response.' | |||
typeof error.message === 'string' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand, now all errors will be ignored? What problem is this fixing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but now not only this example error is ignored, but all errors. Which other errors are happening and why should they be ignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#6950
What is it?
Description
Checklist:
pnpm change
and documented my changes