Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a bug that error in the middleware occurs 404 #6951

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JerryWu1234
Copy link
Contributor

#6950

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested review from a team as code owners October 9, 2024 09:06
Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 27143e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 9, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 27143e4

.changeset/gorgeous-garlics-melt.md Outdated Show resolved Hide resolved
@@ -8,8 +8,7 @@ export const onRequest: RequestHandler = async ({ next }) => {
error &&
typeof error === 'object' &&
'message' in error &&
typeof error.message === 'string' &&
error.message == 'ERROR: Demonstration of an error response.'
typeof error.message === 'string'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, now all errors will be ignored? What problem is this fixing?

Copy link
Contributor Author

@JerryWu1234 JerryWu1234 Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
this error because is error.message was ignored by layout.tsx.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but now not only this example error is ignored, but all errors. Which other errors are happening and why should they be ignored?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but now not only this example error is ignored, but all errors. Which other errors are happening and why should they be ignored?

image

this is only thing I can trace back to.

I guess this just block error message in build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants