Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Final Death Not Showing in Live Fire/Fastball/other round based modes #757

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

EnderBoy9217
Copy link
Contributor

@EnderBoy9217 EnderBoy9217 commented Oct 22, 2023

The bug was that the final kill of each round would not show on the scoreboard as a death for the victim.

The regression was introduced in #72 and applied to all round-based gamemodes
Fixes the "Whatever fixed end of round survivors still receiving a death on the scoreboard when round ends, also introduced a bug where the last player killed doesn't receive a death either now." issue made by @GeckoEidechse in #132

Tested in Live Fire and Fastball, also tested in Attrition to make sure it didn't break anything else.
Clearing entities on round end or game end still does not add deaths to scoreboard and everything functions as intended.

@ASpoonPlaysGames
Copy link
Contributor

I think this needs some more testing perhaps.

Looking at the SetWinner code in _gamestate_mp.nut both round based and normal modes enter the WinnerDetermined state, so I'm not sure if this change doesn't have any unintended side-effects

@EnderBoy9217
Copy link
Contributor Author

EnderBoy9217 commented Oct 22, 2023

I played an Attrition round with this change and it seemed unaffected.
In theory it would count some deaths after the round ends and the screen starts fading to black, however, the game either goes straight to epilogue or fades to black and postmatch shortly afterwards.

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants