-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transferring active Stim ability to Titan and endless stim effects #864
base: main
Are you sure you want to change the base?
Conversation
This adds a new modified vanilla file, right? ^^ |
Yes. |
Which VPK/path? Cause then I fixup the PR to add that file first and then layer change on top of it. That way it's easier to see what got changed and gets the PR merged faster :D |
|
In current version, if pilot has active Stim ability when embarking Titan, it'll be "transfered" to Titan. That's mostly noticeable when Stim has increased duration.
Tested with applied "bc_super_stim" mod. Notice Titan max velocity change after activating Stim:
NkH2YVR2.mp4
PR also applies fix for endless stim not having visual effects and sound not looping. However, there's still a problem with sound - sometimes even TF|1 looping sound stops working. I can't find a cause of this, but I suspect there's a limit of active sounds on entity, because it stops playing after pilot received a lot of damage.