Using PairState enum for paired status of remote bluetooth device. #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,11 @@ | |||
| {"name": "timeReceived", "type": "double", "doc": "Device receiver timestamp in UTC (s)."}, | |||
| {"name": "macAddressHash", "type": ["null", "bytes"], "default": null, "doc":"Hash of Nearby Bluetooth device MAC address."}, | |||
| {"name": "hashSaltReference", "type": ["null", "int"], "doc": "Random identifier associated with the device or installation of the app. If the app gets reinstalled or installed on another device, it's clear during analysis that the mac addresses between iterations are not comparable.", "default": null}, | |||
| {"name": "isPaired", "type": ["null","boolean"], "doc": "Whether the bluetooth device is paired.", "default": null} | |||
There was a problem hiding this comment.
I would not delete this owing to schema evolution and backwards compatibility. You can keep this as is and update the doc to say this is deprecated in favour of pairedState in newer versions.
As a rule, we never delete any fields and always add null default in new fields in any existing schema.
PS: nice spot @afolarin
There was a problem hiding this comment.
Thanks, nice to know about it. I will be updating this accordingly.
|
Merging to include in 0.8.7 release |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier the pairing state of the remote device is calculated manually, but there is also a straightforward and precise way here.