Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of Redirects for LoginActivity into Distinct Intent-Filter Tags #148

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

this-Aditya
Copy link
Member

@this-Aditya this-Aditya commented Sep 23, 2024

Currently, the redirects for the LoginActivity support one app link: https://radar-base.org
and one custom URI:org.radarbase.prmt://radar-base.org

These are declared as data tags within the same intent filter. However, according to Android documentation, they should be specified in separate intent filters. Failing to do so results in a permutation of both data tags, leading to four unintended links.

Supports: https://github.com/RADAR-base/hydra-kratos/issues/52

@this-Aditya
Copy link
Member Author

Tested with the commands:
$ adb shell am start -W -a android.intent.action.VIEW -d "org.radarbase.prmt://radar-base.org" org.radarcns.detail,

$ adb shell am start -W -a android.intent.action.VIEW -d "https://radar-base.org/prmt" org.radarcns.detail

Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants