Increase default length limit #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
All checks failed, but probably not related xD |
|
Ah it is related, we expect failure in the test, but it now passes, can you increase the test commit length pls? |
|
Tests are failing because of this change in the dependency: pawamoy/git-changelog@f191ed7 |
lzap
force-pushed
the
length-limit
branch
2 times, most recently
from
480d30a
to
7e0871c
Compare
|
Fixed tests, this needs git-changelog 2.5 or higher now, which no longer works with Python 3.7. Therefore I am bumping supported Python versions up a notch. |
lzap
commented
Sep 20, 2024
| @@ -1,6 +1,6 @@ | |||
| import sys | |||
|
|
|||
| def check_commit(commit, jira_project, length_limit=70) -> int: | |||
| def check_commit(commit, jira_project, length_limit=135) -> int: | |||
There was a problem hiding this comment.
Totally not a birth date of someone I know :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it is not configurable, I am increasing, how about that?