Enable GEMM/dot for FP8 using hipblasLT #3577
Conversation
CharlieL7
added
simple
| @@ -129,9 +129,11 @@ std::vector<pass> target::get_passes(migraphx::context& gctx, const compile_opti | |||
| unsupported_fp8e4m3fnuz_ops.insert("argmin"); | |||
|
|
|||
| std::set<std::string> unsupported_fp8ocp_ops = {}; | |||
| // TODO update with hipBLASLt support | |||
| // TODO: remove this when the flag is removed | |||
| #if !MIGRAPHX_ENABLE_HIPBLASLT_GEMM | |||
There was a problem hiding this comment.
Probably need to do MIGRAPHX_DECLARE_ENV_VAR(MIGRAPHX_ENABLE_HIPBLASLT_GEMM) at the top of the file...
There was a problem hiding this comment.
I'm not sure what that does exactly. Is the env variable not declared elsewhere?
There was a problem hiding this comment.
This seems to be the way MIGraphX handles env vars. Doing this provides functions like enabled/disabled etc to work with the env vars, so we can set any of the following values for the env variable:
Set to "1", "enable", "enabled", "yes", or "true" to use.
Also, I missed to mention that we should do if(not enabled(MIGRAPHX_ENABLE_HIPBLASLT_GEMM{})) instead of !MIGRAPHX_ENABLE_HIPBLASLT_GEMM, for guarding using the env variable.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3577 +/- ##
========================================
Coverage 92.16% 92.16%
========================================
Files 512 512
Lines 21403 21403
========================================
Hits 19726 19726
Misses 1677 1677 ☔ View full report in Codecov by Sentry. |
Looks to work correctly on Navi4X