Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about new contraction data type and permutation feature to README #167

Merged
merged 12 commits into from
Jan 30, 2024
Merged

Add info about new contraction data type and permutation feature to README #167

merged 12 commits into from
Jan 30, 2024

Conversation

CongMa13
Copy link
Collaborator

@CongMa13 CongMa13 commented Dec 11, 2023 •
edited
Loading

Add info about new contraction data type and permutation feature to README

@CongMa13 CongMa13 marked this pull request as ready for review December 11, 2023 17:47
@CongMa13 CongMa13 added the ci:docs-only Skip most non-doc CI checks for this PR label Dec 11, 2023
LisaDelaney
LisaDelaney reviewed Dec 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Dec 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Dec 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Dec 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Dec 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Dec 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Dec 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Dec 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@cgmillette cgmillette added the documentation Improvements or additions to documentation label Jan 2, 2024
@CongMa13
Copy link
Collaborator Author

CongMa13 commented Jan 2, 2024

Hi @LisaDelaney , I have made changes you suggested. Could you review it again?

LisaDelaney
LisaDelaney reviewed Jan 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Jan 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Jan 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Jan 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Jan 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@CongMa13
Copy link
Collaborator Author

CongMa13 commented Jan 5, 2024

Hi @LisaDelaney , the changes you suggested have been merged. Could you review it again?

@CongMa13
Copy link
Collaborator Author

CongMa13 commented Jan 9, 2024

Hi @LisaDelaney , @saadrahim , could you please approve this PR if it looks good to you? I can merge it after your approval. Thanks.

LisaDelaney
LisaDelaney reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Jan 10, 2024
View reviewed changes
README.md Show resolved Hide resolved
LisaDelaney
LisaDelaney reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
CongMa13 and others added 2 commits January 10, 2024 21:03
@CongMa13 @LisaDelaney
Apply suggestions from code review
174bb8b 
Co-authored-by: Lisa <lisajdelaney@gmail.com>
@CongMa13
Update README.md
408aa8c
@CongMa13
Copy link
Collaborator Author

Hi @LisaDelaney , the README.md has been updated as you suggested. Could you approve this PR if it's ready to go?

LisaDelaney
LisaDelaney previously approved these changes Jan 12, 2024
View reviewed changes
@CongMa13
Avoid Latex in README.md
0d3f5be 
Sphinx throws an error about the `\alpha` in the Latex expression.
@CongMa13
Fix spelling errors
743c2f1 
Fix spelling errors reported by Spelling Check
@CongMa13
Add file .wordlist.txt
541799f 
.wordlist.txt is customized dictionary used by SpellCheck
@CongMa13
Copy link
Collaborator Author

Hi @LisaDelaney , could you approve this PR again.

Sorry to ask you to do this again.

Deleted this line from README.md to make it to pass all the checks.

hiptensor supports a tensor contraction of the form $D = \alpha AB + \beta C$

Remove it since readthedocs does not accept the Latex expression in this line.

@LisaDelaney
Copy link
Contributor

Hi @LisaDelaney , could you approve this PR again.

Sorry to ask you to do this again.

Deleted this line from README.md to make it to pass all the checks.

hiptensor supports a tensor contraction of the form $D = \alpha AB + \beta C$

Remove it since readthedocs does not accept the Latex expression in this line.

If you want to leave it in, I can find math syntax that works...just let me know.

mkarunan
mkarunan approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@mkarunan mkarunan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CongMa13 CongMa13 merged commit b9c8864 into ROCm:develop Jan 30, 2024
6 checks passed
@CongMa13 CongMa13 deleted the change_readme branch May 3, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaDelaney LisaDelaney LisaDelaney approved these changes

@mkarunan mkarunan mkarunan approved these changes

@saadrahim saadrahim Awaiting requested review from saadrahim

@cgmillette cgmillette Awaiting requested review from cgmillette cgmillette is a code owner

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@dlangbe dlangbe Awaiting requested review from dlangbe dlangbe is a code owner

@afanfa afanfa Awaiting requested review from afanfa afanfa is a code owner

Assignees
No one assigned
Labels
ci:docs-only Skip most non-doc CI checks for this PR documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CongMa13 @LisaDelaney @mkarunan @cgmillette