Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New single kernel selection. To be improved. #172

Closed
wants to merge 1 commit into from

Conversation

afanfa
Copy link
Contributor

@afanfa afanfa commented Dec 19, 2023

All new cases now have only one option as "best" kernel. Needs to be improved. The selected kernels are compatible with all sizes tested and behave ok (but not optimally) with most of the sizes.

@CongMa13
Copy link
Collaborator

All new cases now have only one option as "best" kernel. Needs to be improved. The selected kernels are compatible with all sizes tested and behave ok (but not optimally) with most of the sizes.

Great, thanks for the update. Could we enable HIPTENSOR_ALGO_ACTOR_CRITIC in test/01_contraction/configs/*_test_params.yaml since the selected instance can handle all sized tests now?

@cgmillette
Copy link
Collaborator

All new cases now have only one option as "best" kernel. Needs to be improved. The selected kernels are compatible with all sizes tested and behave ok (but not optimally) with most of the sizes.

Great, thanks for the update. Could we enable HIPTENSOR_ALGO_ACTOR_CRITIC in test/01_contraction/configs/*_test_params.yaml since the selected instance can handle all sized tests now?

Yeah, I think we can push that change with this PR

@CongMa13
Copy link
Collaborator

CongMa13 commented Jan 4, 2024

This commit has been cherry-picked to another PR #174. So we will close this PR.

@CongMa13 CongMa13 closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants