Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gfxTargets for ASAN pipeline #247

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

CongMa13
Copy link
Collaborator

@CongMa13 CongMa13 commented Jul 10, 2024

ASAN needs xnack feature. Enable xnack of all targets.

command used for asan VS. command used for non-asan

image

@CongMa13 CongMa13 marked this pull request as ready for review July 10, 2024 20:21
dlangbe
dlangbe previously approved these changes Jul 10, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
ASAN needs xnack feature. Enable xnack of all targets.
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CongMa13 CongMa13 merged commit bb310ca into ROCm:develop Jul 16, 2024
11 checks passed
@CongMa13 CongMa13 deleted the asan_targets branch August 20, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants