Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for permutation cpu reference impl #253

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jakpiase
Copy link
Contributor

Fix for permutation cpu reference impl needed in #251. Current reference implementation doesn't work correctly in some of cases and is a bit overengineered so I have made a new, simpler one which gives proper results. I have tested it on #251 branch and both rank5 and rank6 permutation tests are passing with it.

Copy link
Collaborator

@CongMa13 CongMa13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you for the fix.

The code is cleaner than before.

Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgmillette cgmillette merged commit 80e9f99 into ROCm:develop Jul 26, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants